> On Oct. 9, 2015, 7:02 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 39 > > <https://reviews.apache.org/r/39181/diff/2/?file=1094170#file1094170line39> > > > > FYI: `future.hpp` actually requires `check.hpp`, but this requirement > > was actually hidden because `posix/windows.hpp` included `os.hpp`, which > > itself includes `check.hpp`. > > > > But, since we don't want or need `os.hpp` (including it would block the > > Windows port of this file), we have to place this `#include` here.
ThiSorry, I must have thought future.hpp was in stout or something stupid like this. I've moved this change to #39201. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/#review102099 ----------------------------------------------------------- On Oct. 10, 2015, 4:29 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39181/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2015, 4:29 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3630 and MESOS-3631 > https://issues.apache.org/jira/browse/MESOS-3630 > https://issues.apache.org/jira/browse/MESOS-3631 > > > Repository: mesos > > > Description > ------- > > Windows: Added support for `stout/net.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 3f829bafe96526bc2263c9f228f85de38c435f60 > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/net.hpp > 11e3895ee46e36faca0d2e1b436b61576826e472 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/net.hpp > 4f82796c2b9ef6a9198be145d969c5fce933be49 > > Diff: https://reviews.apache.org/r/39181/diff/ > > > Testing > ------- > > Ran stout tests from VS. > > > Thanks, > > Alex Clemmer > >
