----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101451 -----------------------------------------------------------
Incomplete review on v13. Continuing on the latest version. 3rdparty/libprocess/include/process/digest.hpp (line 40) <https://reviews.apache.org/r/38747/#comment158837> `/**` for doxygen comments. 3rdparty/libprocess/include/process/digest.hpp (line 59) <https://reviews.apache.org/r/38747/#comment158840> Relying on templates and traits or not, these should not be exposed in the same place where the "public" methods are seen. Put then in a "internal" namespace is a conventional practice. 3rdparty/libprocess/include/process/digest.hpp (line 61) <https://reviews.apache.org/r/38747/#comment158852> Consider using `boost::shared_array<char> data` (see io.cpp). 3rdparty/libprocess/include/process/digest.hpp (line 66) <https://reviews.apache.org/r/38747/#comment158845> No need to start a new line for a single argument. 3rdparty/libprocess/include/process/digest.hpp (line 67) <https://reviews.apache.org/r/38747/#comment158846> With `then()` you can get `size_t` result directly so no need for taking a future here. 3rdparty/libprocess/include/process/digest.hpp (lines 73 - 75) <https://reviews.apache.org/r/38747/#comment158851> What does this mean? EOF? Add a comment? Also, we don't need to special case this right? It will terminate at the next iteration right? 3rdparty/libprocess/include/process/digest.hpp (line 299) <https://reviews.apache.org/r/38747/#comment158853> Would it be safer to just have the caller select from the `Digest` enum? - Jiang Yan Xu On Oct. 7, 2015, 7:37 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38747/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 7:37 p.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added SHA256, SHA512 implementation. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 > 3rdparty/libprocess/include/Makefile.am > fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e > 3rdparty/libprocess/include/process/digest.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/CMakeLists.txt > a14b5b8fe22d3e75bef3c716ae7865ddaf132927 > 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38747/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
