-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/#review102382
-----------------------------------------------------------



include/mesos/resources.hpp (line 75)
<https://reviews.apache.org/r/39018/#comment160009>

    s/Try/`Try`



include/mesos/resources.hpp (line 92)
<https://reviews.apache.org/r/39018/#comment160010>

    s/Try/`Try`



include/mesos/resources.hpp (lines 113 - 117)
<https://reviews.apache.org/r/39018/#comment160013>

    Can this be removed or merged to the under comments?



include/mesos/resources.hpp (line 119)
<https://reviews.apache.org/r/39018/#comment160011>

    s/Validates/Validate



include/mesos/resources.hpp (line 121)
<https://reviews.apache.org/r/39018/#comment160012>

    ditto



include/mesos/resources.hpp (line 357)
<https://reviews.apache.org/r/39018/#comment160014>

    Can we add a simple example for a JSON Object resource in the comments? 
This can make the user more clear for how to define a JSON Object resource.



include/mesos/resources.hpp (line 360)
<https://reviews.apache.org/r/39018/#comment160016>

    s/Try/`Try`



include/mesos/resources.hpp (line 374)
<https://reviews.apache.org/r/39018/#comment160015>

    Can we add a simple example for a JSON Array resource in the comments? This 
can make the user more clear for how to define a JSON Array resource.



include/mesos/resources.hpp (line 377)
<https://reviews.apache.org/r/39018/#comment160017>

    s/Try/`Try`



include/mesos/resources.hpp (line 393)
<https://reviews.apache.org/r/39018/#comment160018>

    s/Option/`Option`



include/mesos/resources.hpp (line 411)
<https://reviews.apache.org/r/39018/#comment160020>

    s/conflictingTypes/conflictTypes?


- Guangya Liu


On 十月 12, 2015, 6:38 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> -----------------------------------------------------------
> 
> (Updated 十月 12, 2015, 6:38 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2467
>     https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This includes code changes necessary for JSON parsing of Resources. 
> Documentation changes will be posted soon in another review 
> (https://reviews.apache.org/r/39102/).
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39018/diff/
> 
> 
> Testing
> -------
> 
> New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were 
> added: `ResourcesTest.ParsingFromJSONWithRoles` and 
> `ResourcesTest.ParsingFromJSONError`. These attempt to test common error 
> scenarios that might show up in user-supplied JSON.
> 
> `make check` was used to confirm that all tests pass, with one notable 
> failure (ResourcesTest.ParsingFromJSONError) related to a picojson issue 
> tracked here: https://issues.apache.org/jira/browse/MESOS-3698
> 
> The original resources parsing format is used throughout many other tests 
> (check `src/tests/sorter_tests.cpp`, for example), so it's clear that the 
> original parsing continues to work correctly.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to