----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review102495 -----------------------------------------------------------
Thanks for doing this! One minor issue about the use of the factory stuff below. src/master/allocator/mesos/hierarchical.hpp (lines 65 - 91) <https://reviews.apache.org/r/38869/#comment160175> Do we need all of this factory stuff here? Any reason we can't just pass in std::functions as the factories instead of having the polymorphism indirection here? - Ben Mahler On Oct. 13, 2015, 8:51 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38869/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 8:51 a.m.) > > > Review request for mesos, Ben Mahler, Cody Maloney, Artem Harutyunyan, Joseph > Wu, and Michael Park. > > > Bugs: MESOS-3554 > https://issues.apache.org/jira/browse/MESOS-3554 > > > Repository: mesos > > > Description > ------- > > This improves the compilation time of Mesos significantly, allowing > developers to iterate more quickly on allocator changes. > > > Diffs > ----- > > src/CMakeLists.txt 536a99f3dc2f48e6002e70b605598f4d218a4324 > src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e > src/master/allocator/mesos/hierarchical.hpp > d57c55e2f173c3054a04322a33ba590c67b82e4e > src/master/allocator/mesos/hierarchical.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38869/diff/ > > > Testing > ------- > > make check > touched hierarchical.cpp and recompiled. Verified we only rebuild the module > and relink. > > > Thanks, > > Joris Van Remoortere > >
