----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review102731 -----------------------------------------------------------
Ship it! src/master/master.cpp (line 6022) <https://reviews.apache.org/r/38051/#comment160472> s/transited/transitioned/ ? src/tests/status_update_manager_tests.cpp (line 844) <https://reviews.apache.org/r/38051/#comment160473> new line. src/tests/status_update_manager_tests.cpp (lines 845 - 849) <https://reviews.apache.org/r/38051/#comment160476> This comment is a bit confusing. The fix in this review is for master and not slave/status update manager. Why is this comment talking about semantics of slave/status update manager? How about? // This test verifies that if master receives a status update for an already terminated // task it forwards it without changing the state of the task. src/tests/status_update_manager_tests.cpp (line 943) <https://reviews.apache.org/r/38051/#comment160580> No need for settle() here. - Vinod Kone On Sept. 24, 2015, 9:45 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 9:45 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > ------- > > Only update the task status when its old status is not terminal. > > > Diffs > ----- > > src/master/master.cpp 6bee4f3 > src/tests/status_update_manager_tests.cpp 9970d71 > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > ------- > > UT: > 1. Write a test for this change. > 2. make successfully! > 3. make check successfully! > 4. Run test framework successfully! > > > Thanks, > > Yong Qiao Wang > >
