----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/ -----------------------------------------------------------
(Updated Oct. 15, 2015, 5:30 p.m.) Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone. Changes ------- Change the other `return` to an `exit` in the constructor. Bugs: MESOS-3748 https://issues.apache.org/jira/browse/MESOS-3748 Repository: mesos Description (updated) ------- The master detector is created during construction of the `MesosProcess`. If the flags cannot be loaded or if the `MasterDetector::create` fails, the master detector will be null and will result in a segfault if it is used during initialization. Diffs (updated) ----- src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712 Diff: https://reviews.apache.org/r/39365/diff/ Testing ------- `make check` ``` export DEFAULT_PRINCIPAL=root build/src/event-call-framework --master="asdf://127.0.0.1:5050" ``` Check that it does not segfault. Thanks, Joseph Wu