----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39368/#review102861 -----------------------------------------------------------
Ship it! src/common/http.cpp (line 68) <https://reviews.apache.org/r/39368/#comment160658> static? src/common/http.cpp (line 101) <https://reviews.apache.org/r/39368/#comment160656> Not yours, but any reason need this temp variable? Can we just do: ``` foreachpair (.., .., nonRevocable.types()) ``` Also, I prefer Value::Type than Value_Type src/common/http.cpp (line 103) <https://reviews.apache.org/r/39368/#comment160659> s/Value_Type/Value::Type/ src/common/http.cpp (line 110) <https://reviews.apache.org/r/39368/#comment160657> Ditto here. src/common/http.cpp (line 112) <https://reviews.apache.org/r/39368/#comment160660> s/Value_Type/Value::Type/ - Jie Yu On Oct. 16, 2015, 12:48 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39368/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 12:48 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-3563 > https://issues.apache.org/jira/browse/MESOS-3563 > > > Repository: mesos > > > Description > ------- > > Revocable resources now show up in the state.json endpoint with "_revocable" > suffix. > > > Diffs > ----- > > src/common/http.cpp 99b843afac8bb07ef233c70117f52e64747f9502 > src/tests/common/http_tests.cpp 8a01ffc655f9c19f776da2f99283a9ffdd7020aa > > Diff: https://reviews.apache.org/r/39368/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
