> On Oct. 15, 2015, 8:58 p.m., James Peach wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ftruncate.hpp, > > line 30 > > <https://reviews.apache.org/r/39217/diff/4/?file=1099166#file1099166line30> > > > > Should this be ```_chsize_s``` so you can use a large offset?
Ah. I didn't know about that function. Yes, that looks like an improvement! Thanks! - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102822 ----------------------------------------------------------- On Oct. 15, 2015, 8:36 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39217/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 8:36 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Added `stout/os/chsize.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os/ftruncate.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ftruncate.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ftruncate.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39217/diff/ > > > Testing > ------- > > Built CMake solution and ran `make check` (or equivalent) on Windows 10, > Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on > Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
