----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39209/#review103038 -----------------------------------------------------------
Ship it! Changing the summary to reflect the code change. - Joris Van Remoortere On Oct. 13, 2015, 6:33 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39209/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 6:33 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > The `Windows.h` head includes a header that defines the UUID struct for > the DCE RPC API. This is dumped into the global namespace, just like our > UUID implementation found in `stout/uuid.hpp`. > > Since this causes a compilation error on Windows, we simply move our > UUID into `stout::`. We further add a `using stout::UUID;` in the file > so that we don't have to change every callsite in the Mesos codebase > that uses it. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp > bc167f1fa9e64f89138f131e726e7733c66da29c > > Diff: https://reviews.apache.org/r/39209/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
