> On Oct. 18, 2015, 7:14 a.m., Guangya Liu wrote: > > support/apply-reviews.py, lines 272-274 > > <https://reviews.apache.org/r/39420/diff/1/?file=1100573#file1100573line272> > > > > Tab or blank space? If Tab, we should switch to blank space
Thanks for spotting this! My editor was sneaking tabs in this whole time. I went back and cleaned previous reviews as well. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103056 ----------------------------------------------------------- On Oct. 18, 2015, 3:33 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39420/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 3:33 p.m.) > > > Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > Added '--parent' option and made apply-review.sh call apply-reviews.py. > > > Diffs > ----- > > support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/39420/diff/ > > > Testing > ------- > > Tested with python 2.7. > > - with and without '-p'. > - Tested reviews with and without parents. > > > Thanks, > > Artem Harutyunyan > >
