> On Oct. 16, 2015, 5:30 p.m., Marco Massenzio wrote: > > Thanks for doing this. > > > > I think you will need to document the flags' usage in `configuration.md` > > (or wherever appropriate) and state clearly that it's **required** and what > > it should point to (in other words, what binary(ies) will we be looking > > for?) - or users will be confused by the error message. > > Marco Massenzio wrote: > Actually - would it be possible to add a unit test to catch the scenario > that was reported in the Jira and make sure this fixes it? > (when it comes to interaction between OS env vars and flags, it's always > tricky)
Because we pass the launcher_dir flag directly instead of get it from argv. If the HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange could pass, it show the launcher_dir is correct. So I don't add new test cases here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review102939 ----------------------------------------------------------- On Oct. 19, 2015, 2:59 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39386/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 2:59 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3738 > https://issues.apache.org/jira/browse/MESOS-3738 > > > Repository: mesos > > > Description > ------- > > Fix uncorrect launcher dir in docker executor. > > > Diffs > ----- > > docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 > src/docker/executor.hpp 8ab4e98c41017e8420b98c63a59d8e4bc1a99172 > src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade > src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > > Diff: https://reviews.apache.org/r/39386/diff/ > > > Testing > ------- > > * make check > * make install and then test with marathon to check if launcher_dir passes > correctly. > > > Thanks, > > haosdent huang > >
