----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review103147 -----------------------------------------------------------
support/apply-reviews.py (line 12) <https://reviews.apache.org/r/38705/#comment161109> s/rid/review_id/ here and everywhere else. support/apply-reviews.py (line 22) <https://reviews.apache.org/r/38705/#comment161104> why not have this return JSON instead of string? support/apply-reviews.py (line 25) <https://reviews.apache.org/r/38705/#comment161107> s/extract/review/ support/apply-reviews.py (line 32) <https://reviews.apache.org/r/38705/#comment161110> s/r_list/reviews/ also, the function name is misleading. how about s/parent_review/review_chain/ ? support/apply-reviews.py (lines 33 - 34) <https://reviews.apache.org/r/38705/#comment161111> what does "reversed chain of review requests for a given Review ID" mean? i'm assuming you mean dependent reviews? please make that more clear. support/apply-reviews.py (lines 35 - 36) <https://reviews.apache.org/r/38705/#comment161105> if review_json returns json, this could be json = review_json(review_url(rid)) support/apply-reviews.py (line 43) <https://reviews.apache.org/r/38705/#comment161106> s/A may/A review may/ do we want to allow reviews that have more than one parent review? what does that mean for the order of reviews to be applied? i think it makes sense to disallow such reviews. throw an error. support/apply-reviews.py (lines 49 - 52) <https://reviews.apache.org/r/38705/#comment161113> i don't follow what's happening here. you are appending the same <rid,summary> pair multiple times to the list? support/apply-reviews.py (line 56) <https://reviews.apache.org/r/38705/#comment161093> 2 lines. support/apply-reviews.py (line 75) <https://reviews.apache.org/r/38705/#comment161103> seems weird to have this function return the command if dry_run is true and None otherwise. how about just prefixing "echo" to the command if dry_run is true? support/apply-reviews.py (line 101) <https://reviews.apache.org/r/38705/#comment161108> s/print // - Vinod Kone On Oct. 18, 2015, 10:30 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38705/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 10:30 p.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38705/diff/ > > > Testing > ------- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
