----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103314 -----------------------------------------------------------
docs/scheduler-http-api.md (lines 29 - 34) <https://reviews.apache.org/r/39452/#comment161300> Now that there is a formal grammar this example should be removed. docs/scheduler-http-api.md (lines 36 - 48) <https://reviews.apache.org/r/39452/#comment161294> The proposed grammar I made was based of the ABNF of the HTTP 1.1 spec here: http://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html#sec2.1 This spec should probably be linked to so the user can follow it. `LF` is the method used to refer to `\n` character and I think we should be consistent with that. `1*(DIGIT)` was there to denote the repetition of digit. Meaning at least 1 digit. `DIGIT` is already defined in the rfc I linked to. `NL` is non-standard and should be removed in favor of `LF` docs/scheduler-http-api.md (line 51) <https://reviews.apache.org/r/39452/#comment161295> This section of the document is expalaining RecordIO not http clients. Please remove this sentence. docs/scheduler-http-api.md (lines 66 - 68) <https://reviews.apache.org/r/39452/#comment161299> These two lines don't flow together very well, a single paragraph should contain the motivation and justification. - Ben Whitehead On Oct. 20, 2015, 2:58 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39452/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 2:58 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3566 > https://issues.apache.org/jira/browse/MESOS-3566 > > > Repository: mesos > > > Description > ------- > > Added the description of the RecordIO format to the HTTP API > document with example code (Python) to decode. > > > Diffs > ----- > > docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 > > Diff: https://reviews.apache.org/r/39452/diff/ > > > Testing > ------- > > > Thanks, > > Marco Massenzio > >
