> On Oct. 21, 2015, 5:25 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/process.cpp, lines 841-842 > > <https://reviews.apache.org/r/37999/diff/8/?file=1101615#file1101615line841> > > > > If an `authenticate`-request failed, the error message is never shown > > anywhere. > > > > I think we should add something that helps us debugging the > > authentication via logs. > > > > Something like this would possibly do: > > ``` > > } else { > > LOG(WARNING) << "Authentication failed: " << > > result.error(); > > } > > ```
Using `VLOG` since we are in libprocess here. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review103347 ----------------------------------------------------------- On Oct. 20, 2015, noon, Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37999/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, noon) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3231 > https://issues.apache.org/jira/browse/MESOS-3231 > > > Repository: mesos > > > Description > ------- > > Introduces the authenticator manager, which is a class which handles the > actual authentication procedure during the execution of > `ProcessManager::handle()` and it also takes care of the life cycle of > instances of http::Authenticator. > > No tests are added at this point since no public API is generated, the goal > of this patch is to implement the manager and verify nothing breaks > afterwards. Authenticator manager tests proper come in a latter patch. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e > 3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION > 3rdparty/libprocess/include/process/event.hpp > 16ddbd77afa6efdf6bad201aa497ee102aa863ae > 3rdparty/libprocess/include/process/http.hpp > 591c1a959057155e1bf0f5bd73352e78d1c15cb3 > 3rdparty/libprocess/src/process.cpp > 954d31424bc8f8ecfa78b80513c480f2514ec271 > > Diff: https://reviews.apache.org/r/37999/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
