> On Oct. 21, 2015, 10:40 p.m., Ben Mahler wrote: > > Curious if we want to scope these for the whole files? Might be a bit hard > > to scope this correctly over time.
True that - also I noticed that I can totally not include the clang specific pragma as clang does pick up the GCC specifics already. > On Oct. 21, 2015, 10:40 p.m., Ben Mahler wrote: > > configure.ac, lines 769-774 > > <https://reviews.apache.org/r/39230/diff/2/?file=1098841#file1098841line769> > > > > Could you include the comment here as well? Aye.... - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review103488 ----------------------------------------------------------- On Oct. 19, 2015, 4:27 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39230/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 4:27 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3030 > https://issues.apache.org/jira/browse/MESOS-3030 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > configure.ac 66f9b32 > src/authentication/cram_md5/authenticatee.cpp b03b44a > src/authentication/cram_md5/authenticator.cpp f238872 > src/authentication/cram_md5/auxprop.cpp abf0f8d > > Diff: https://reviews.apache.org/r/39230/diff/ > > > Testing > ------- > > ./configure && make check > OSX, clang3.7 + gcc4.9 > > > Thanks, > > Till Toenshoff > >
