----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review103906 -----------------------------------------------------------
Patch looks great! Reviews applied: [39569, 38874, 38875, 39297, 38876, 38877, 38878] All tests passed. - Mesos ReviewBot On Oct. 24, 2015, 7 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38878/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 7 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-3515 > https://issues.apache.org/jira/browse/MESOS-3515 > > > Repository: mesos > > > Description > ------- > > This change adds a basic test to validate the implementation for > Subscribe->Subscribed workflow on the `api/v1/executor` endpoint on Agent. > > > Diffs > ----- > > src/tests/executor_http_api_tests.cpp > 31938c295367686d444f8a8aa2c43d2696b481ec > > Diff: https://reviews.apache.org/r/38878/diff/ > > > Testing > ------- > > make check. Would add more agent recovery tests/executor reconnect tests in a > separate patch. > > > Thanks, > > Anand Mazumdar > >