----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39695/#review104204 -----------------------------------------------------------
Patch looks great! Reviews applied: [39695] All tests passed. - Mesos ReviewBot On Oct. 27, 2015, 6:30 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39695/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 6:30 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3129 > https://issues.apache.org/jira/browse/MESOS-3129 > > > Repository: mesos > > > Description > ------- > > Relocate launcher and linux_launcher as MesosContainerizer specific > > > Diffs > ----- > > src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd > src/Makefile.am e797dac8093150871e9b68eba868f87df680ab43 > src/slave/containerizer/containerizer.cpp > 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b > src/slave/containerizer/external_containerizer.hpp > c00cebb93c5395bccbef558632d8f9c9bee8fffa > src/slave/containerizer/launcher.hpp > src/slave/containerizer/launcher.cpp > 668ae80d0723068f85f7c16e0cc57804bb55af16 > src/slave/containerizer/linux_launcher.hpp > 627df892728f127f37672991e1a57ee445008fe1 > src/slave/containerizer/linux_launcher.cpp > c0adb34771fdb5a85d087296a8f98b890254ddf7 > src/slave/containerizer/mesos/containerizer.hpp > 4aad8a3be43b331efc6b8157b2fae090df16c1b4 > src/slave/containerizer/mesos/containerizer.cpp > 91e4ea3a907ad165c359e7422135138737e14085 > src/tests/containerizer/filesystem_isolator_tests.cpp > 39008f6201777783d242407fea5377bfceffc57b > src/tests/containerizer/isolator_tests.cpp > 4e1e90ba2aeb70d4a70c3e0cf9796bd1aa199147 > src/tests/containerizer/launcher.hpp > 5d34bab789bdafe71d94e8ec263710c50b83e180 > src/tests/containerizer/mesos_containerizer_tests.cpp > b48133c3d0624b27bcdc2289669c7f0b1bcc12f4 > src/tests/containerizer/port_mapping_tests.cpp > ae2c0e613acf41614413e41e6989e9056328ff36 > > Diff: https://reviews.apache.org/r/39695/diff/ > > > Testing > ------- > > make check (Ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >