----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39827/#review104625 -----------------------------------------------------------
Ship it! Looks good, thank you for doing the cleanup. src/master/master.hpp (line 114) <https://reviews.apache.org/r/39827/#comment162855> My fault, should this be a reference? - Ben Mahler On Oct. 30, 2015, 10:08 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39827/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 10:08 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Slave version is being set by the slave since 0.21.0. Cleaned up the code in > master that expected it to be optional. > > > Diffs > ----- > > src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac > src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 > > Diff: https://reviews.apache.org/r/39827/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
