> On Nov. 1, 2015, 12:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > <https://reviews.apache.org/r/39401/diff/7/?file=1112398#file1112398line1005> > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources for this role on this agent in > > ```roleConsumedResources```? And what about the static reserved resources?
Dynamic reservations should account towards role's quota. [Note about static reservations](https://docs.google.com/document/d/16iRNmziasEjVOblYp5bbkeBZ7pnjNlaIzPQqMTHQ-9I/edit?pli=1#heading=h.xumvch9xiky2) > On Nov. 1, 2015, 12:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > <https://reviews.apache.org/r/39401/diff/7/?file=1112398#file1112398line1035> > > > > Can you please clarify a bit about this TODO? What do we plan to do > > about it in future? It may make sense to allocate reserved but yet unallocated resources during as part of the role's quota. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104656 ----------------------------------------------------------- On Oct. 29, 2015, 7:29 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39401/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 7:29 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39401/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >