----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review104806 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp (lines 20 - 21) <https://reviews.apache.org/r/39802/#comment163051> Add `#include <stout/error.hpp>`? 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp (line 22) <https://reviews.apache.org/r/39802/#comment163052> I might be blind, but I don't see where this is used. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp (lines 66 - 69) <https://reviews.apache.org/r/39802/#comment163049> This seems weird. `readdir_r`, per your implementation, only returns 0 or 1. But in the error case, you set `errno` to `EBADF` within `readdir_r`. I'm guessing you'll want to "preserve" the error, just like you did above for malloc. - Joseph Wu On Oct. 29, 2015, 11:46 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39802/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 11:46 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `stout/os/windows/ls.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp > 5b6fba13ce215af5801fd0867f6e774e100689ca > > Diff: https://reviews.apache.org/r/39802/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
