> On Oct. 23, 2015, 4:53 a.m., Jan Schlicht wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 800 > > <https://reviews.apache.org/r/38335/diff/4/?file=1101469#file1101469line800> > > > > Not yours, but please s/push_back/emplace_back > > Michael Park wrote: > I'm curious as to what your reasoning is?
AFAIK, that'll avoid temp var copy from `JSON::protobuf(...)`'s return to `commandArray.values` - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review103655 ----------------------------------------------------------- On Oct. 20, 2015, 1:37 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38335/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 1:37 p.m.) > > > Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht. > > > Bugs: MESOS-3405 > https://issues.apache.org/jira/browse/MESOS-3405 > > > Repository: mesos > > > Description > ------- > > Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which > converts a `google::protobuf::Message` into a `JSON::Object`. > We should add the support for `google::protobuf::RepeatedPtrField<T>` by > introducing overloaded functions. > > > Diffs > ----- > > src/common/http.cpp f56d8a1 > src/docker/executor.cpp 1e49013 > src/examples/persistent_volume_framework.cpp 176ac3d > src/launcher/executor.cpp 50b3c6e > src/master/contender.cpp c641305 > src/master/http.cpp 093f793 > src/master/maintenance.cpp 5fe9358 > src/master/registrar.cpp 1117232 > src/slave/containerizer/fetcher.cpp e0d02d5 > src/slave/containerizer/mesos/containerizer.cpp d1fc5a4 > src/slave/monitor.cpp aa6e958 > src/tests/containerizer/launch_tests.cpp de655ec > src/tests/fault_tolerance_tests.cpp f78a291 > src/tests/master_maintenance_tests.cpp e89ce3b > src/tests/master_tests.cpp ee24739 > src/tests/mesos.hpp 3e58b45 > src/tests/mesos.cpp ab2d85b > src/tests/monitor_tests.cpp 583e711 > src/tests/reservation_endpoints_tests.cpp f5f9c48 > src/tests/resources_tests.cpp 6584fc6 > src/tests/scheduler_http_api_tests.cpp d338a1b > src/tests/script.cpp bcc1fab > src/tests/slave_tests.cpp 10a4fa7 > src/usage/main.cpp 86fd796 > > Diff: https://reviews.apache.org/r/38335/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
