> On Nov. 4, 2015, 3:30 a.m., Bernd Mathiske wrote: > > src/launcher/fetcher.cpp, line 297 > > <https://reviews.apache.org/r/39707/diff/1/?file=1110421#file1110421line297> > > > > Or, avoiding a string constant: > > > > CHECK_FALSE(item.cache_filename().empty()); > > Vinod Kone wrote: > i don't see a CHECK_FALSE macro in glog?
How about CHECK(!item.cache_filename().empty()) then? Not a biggy. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/#review105053 ----------------------------------------------------------- On Oct. 27, 2015, 6:45 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39707/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 6:45 p.m.) > > > Review request for mesos, Bernd Mathiske and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Made some small refactoring as I was reading through the fetcher code to make > the groking easy. No functional changes. > > > Diffs > ----- > > src/launcher/fetcher.cpp 8fb6c83981a141df9c0a8a6f8267230bef64f218 > > Diff: https://reviews.apache.org/r/39707/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
