----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39839/#review105270 -----------------------------------------------------------
Ship it! Ship It! src/tests/containerizer/provisioner_docker_tests.cpp (line 690) <https://reviews.apache.org/r/39839/#comment163789> style wise, I suggest making this simpler: Future<Manifest> manifestResponseFuture = registryClient.get()->getManifest( parseImageName("library/busybox"), None()); - Timothy Chen On Nov. 5, 2015, 3:50 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39839/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 3:50 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Replaced path and tag parameters with Image::Name > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > ad57d8592c5f9df5115b575855ed2e99a0597359 > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c > src/tests/containerizer/provisioner_docker_tests.cpp > 8d90894410cd834edf49a2814d1b616718798fe8 > > Diff: https://reviews.apache.org/r/39839/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
