----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review105316 -----------------------------------------------------------
Can we add an end-to-end unit test that verifies that attempting to register as a framework with an invalid role name results in an error? include/mesos/roles.hpp (line 46) <https://reviews.apache.org/r/35711/#comment163836> Extra whitespace before period. include/mesos/roles.hpp (line 51) <https://reviews.apache.org/r/35711/#comment163846> Should this be a member function? i.e., not static. include/mesos/roles.hpp (line 53) <https://reviews.apache.org/r/35711/#comment163858> Is this necessary? include/mesos/roles.hpp (line 55) <https://reviews.apache.org/r/35711/#comment163837> Capitalization, punctuation. include/mesos/roles.hpp (line 58) <https://reviews.apache.org/r/35711/#comment163838> Same as above. include/mesos/roles.hpp (line 59) <https://reviews.apache.org/r/35711/#comment163845> Is this necessary? include/mesos/roles.hpp (line 61) <https://reviews.apache.org/r/35711/#comment163857> Is this necessary? include/mesos/roles.hpp (line 63) <https://reviews.apache.org/r/35711/#comment163888> Is this necessary? src/common/roles.cpp (line 19) <https://reviews.apache.org/r/35711/#comment163852> If we're including roles.hpp, we can omit including the headers it includes, I'd think. src/common/roles.cpp (line 67) <https://reviews.apache.org/r/35711/#comment163842> Error message is inaccurate. src/common/roles.cpp (line 90) <https://reviews.apache.org/r/35711/#comment163844> Why are some trivial member functions/constructors define in the .cpp, whereas others are defined in the header file? src/tests/roles_tests.cpp (line 29) <https://reviews.apache.org/r/35711/#comment163892> This can be removed. - Neil Conway On Oct. 3, 2015, 4:11 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2015, 4:11 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > include/mesos/roles.hpp PRE-CREATION > src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 > src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 > src/common/roles.cpp PRE-CREATION > src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 > src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c > src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b > src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 > src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 > src/tests/roles_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
