> On Nov. 12, 2015, 6 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 23 > > <https://reviews.apache.org/r/40225/diff/2/?file=1124332#file1124332line23> > > > > s/ui_// > > > > What's a UI URL? > > Artem Harutyunyan wrote: > BenM noticed that instead of putting the Review Board UI URL in the > commit message (as in https://reviews.apache.org/r/40225/) we had a Review > Board API URL there (as in > https://reviews.apache.org/api/review-requests/40225/). > > Artem Harutyunyan wrote: > RB mangled the second link, it should be > https://reviews.apache.org/api/review-requests/40225/ > > Do you have a suggestion for a better name?
how about just calling it review_url since we already named the other thing review_api_url - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/#review106276 ----------------------------------------------------------- On Nov. 12, 2015, 5:56 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40225/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 5:56 p.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Adjusted Review Board URL in comment. > > > Diffs > ----- > > support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 > > Diff: https://reviews.apache.org/r/40225/diff/ > > > Testing > ------- > > > Thanks, > > Artem Harutyunyan > >
