> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 110-112 > > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line110> > > > > The resource string you have is equivalent to the resource string from > > `CreateSlaveFlags`. Is there some reason you're re-setting it? > > Alexander Rukletsov wrote: > One of the comments I got earlier from Bernd is that it is hard to track > what resources are available, hence I decided to re-introduce the resources > explicitly. > > Joseph Wu wrote: > Can you add a comment about this to the test?
I have introduced the constant in the `MesosTest` fixture and got rid of this fucntion here. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review105339 ----------------------------------------------------------- On Nov. 14, 2015, 3:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2015, 3:46 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
