> On Nov. 16, 2015, 3:23 p.m., Joerg Schad wrote: > > src/tests/mesos.hpp, line 1245 > > <https://reviews.apache.org/r/40346/diff/1/?file=1126219#file1126219line1245> > > > > This looks somehow weird... Who is satisfying the expect_call? > > Guangya Liu wrote: > I also have the same question, seems no one will trigger this.
This call does not need to be called, as described in https://code.google.com/p/googlemock/wiki/CheatSheet#Setting_Expectations `EXPECT_CALL` will assume a cardinality >=0 if used with `WillRepeatedly()`. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review106660 ----------------------------------------------------------- On Nov. 16, 2015, 4:48 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40346/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 4:48 p.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till > Toenshoff. > > > Bugs: MESOS-3862 > https://issues.apache.org/jira/browse/MESOS-3862 > > > Repository: mesos > > > Description > ------- > > Quota: Implemented authorization of quota requests in the authorizer. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > d667a52f90f970a313580446a5a006cec4b5e25b > src/authorizer/local/authorizer.hpp > 32de102fd588f029882ef2222121ca83a7410c65 > src/authorizer/local/authorizer.cpp > 6d7da87731a438c2180cf91003e09d4aa5a1c773 > src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed > > Diff: https://reviews.apache.org/r/40346/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
