-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/
-----------------------------------------------------------
(Updated Nov. 18, 2015, 11:09 a.m.)
Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.
Changes
-------
Address review comments: whitespace.
Bugs: MESOS-3939
https://issues.apache.org/jira/browse/MESOS-3939
Repository: mesos
Description
-------
The previous code took the address of a "struct sockaddr", and then cast the
resulting pointer to "struct sockaddr_storage *". The alignment requirements for
"struct sockaddr_storage *" are more strict than for "struct sockaddr *", and
hence this code produced undefined behavior per ubsan in GCC 5.2.
Along the way, tweak the code to use reinterpret_cast rather than a C-style
cast, and not to unnecessarily cast-away constness.
MESOS-3939.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
6709f5e7f6233983f389203278a0e42694591230
Diff: https://reviews.apache.org/r/40435/diff/
Testing
-------
"make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an
error. With fix, ubsan does not report (this) error.
Thanks,
Neil Conway
