----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40459/#review107158 -----------------------------------------------------------
Patch looks great! Reviews applied: [40459] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Nov. 19, 2015, 12:58 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40459/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 12:58 a.m.) > > > Review request for mesos, haosdent huang and Timothy Chen. > > > Bugs: MESOS-3809 > https://issues.apache.org/jira/browse/MESOS-3809 > > > Repository: mesos > > > Description > ------- > > If set, these IP/Port shall be advertised by libprocess (although bind is not > done on this IP/Port). If not set, libprocess advertises the IP/Port on which > bind was done. > > Command line arguments added: > advertise_ip: IP address advertised to reach mesos slave. > advertise_port: Port advertised to reach mesos slave (used with advertise_ip). > > > Diffs > ----- > > docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0 > src/slave/main.cpp 746eec684a0c9119f85506022676d276f808b6ea > > Diff: https://reviews.apache.org/r/40459/diff/ > > > Testing > ------- > > make check run successfully. > > > Thanks, > > Anindya Sinha > >