> On Nov. 16, 2015, 2:37 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 188 > > <https://reviews.apache.org/r/40347/diff/1/?file=1126222#file1126222line188> > > > > Should this be part of the validation below? > > Jan Schlicht wrote: > I'd rather put it into `createQuotaInfo` as it's not validating but > setting properties of `create`.
Question was whether we should validate that the principal is set in validation... - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review106662 ----------------------------------------------------------- On Nov. 19, 2015, 10:55 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40347/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 10:55 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till > Toenshoff. > > > Bugs: MESOS-3862 > https://issues.apache.org/jira/browse/MESOS-3862 > > > Repository: mesos > > > Description > ------- > > Quota: Implemented quota request authorization. > > > Diffs > ----- > > include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d > src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 > src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f > > Diff: https://reviews.apache.org/r/40347/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
