> On Nov. 19, 2015, 11:10 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 460 > > <https://reviews.apache.org/r/40392/diff/4/?file=1132941#file1132941line460> > > > > Could you please restore this blank line? > > Joerg Schad wrote: > Sure, but FYI this style is consistent with the the rest of the file > where we have one single line between TODO and first test (see line 155/156)
It makes sense to fix it where it was introduced to reduce noise. Agree? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107265 ----------------------------------------------------------- On Nov. 20, 2015, 5:44 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40392/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 5:44 a.m.) > > > Review request for mesos, Alexander Rukletsov and Joris Van Remoortere. > > > Bugs: MESOS-3911 > https://issues.apache.org/jira/browse/MESOS-3911 > > > Repository: mesos > > > Description > ------- > > Added force flag to override quota capacityHeuristic check. > > > Diffs > ----- > > src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40392/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joerg Schad > >
