> On Nov. 3, 2015, 10:56 p.m., Joerg Schad wrote: > > docs/c++-style-guide.md, line 262 > > <https://reviews.apache.org/r/39449/diff/2/?file=1101246#file1101246line262> > > > > This should be the first include (see my other comments and the Google > > Styleguide ( > > https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes) > > :-)).
Yes, it's also my opinion that the related header should be included first. After presenting this at the dev-list there were no comments against it. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review104986 ----------------------------------------------------------- On Oct. 19, 2015, 11:29 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39449/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 11:29 p.m.) > > > Review request for mesos, Marco Massenzio and Michael Park. > > > Bugs: MESOS-2275 > https://issues.apache.org/jira/browse/MESOS-2275 > > > Repository: mesos > > > Description > ------- > > Documented order of includes. > > > Diffs > ----- > > docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad > > Diff: https://reviews.apache.org/r/39449/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >