----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review107365 -----------------------------------------------------------
Ship it! For transparency we pulled out the libprocess integration because we realized that requests sent to the authentication router need to have authentication results satisfied in the same order in which the requests were sent. We're still thinking through how to solve this within libprocess, so for now we're just going to commit these interfaces (we don't expect these interfaces to change further for the MVP). I will update the description in the commit to reflect that this no longer includes the ProcessManager integration. - Ben Mahler On Nov. 20, 2015, 12:53 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37999/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 12:53 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3231 > https://issues.apache.org/jira/browse/MESOS-3231 > > > Repository: mesos > > > Description > ------- > > The Authenticator interface allows us to implement different > authenticators based on the scheme (e.g. Basic, Digest, SPNEGO). > The AuthenticationRouter manages the authentication realms and > the mapping from endpoints to realms. It is then used by the > ProcessManager to route requests to the authenticator for the > realm, if applicable. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 > 3rdparty/libprocess/include/Makefile.am > e6be2c4db121585bbe7f3c0627de048adc7cfb2c > 3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION > 3rdparty/libprocess/include/process/event.hpp > 60c615281f3810230bf6c17866f46eaa6855ca29 > 3rdparty/libprocess/include/process/http.hpp > 90c9be122ee0c402b806d70fc818e3c03b15101a > 3rdparty/libprocess/src/CMakeLists.txt > fb9bd04832779ac43151f2feb3dfbf58cb996434 > 3rdparty/libprocess/src/authentication_router.hpp PRE-CREATION > 3rdparty/libprocess/src/authentication_router.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 7abdf21a5784920251c3627f9820c12fdc356c6e > > Diff: https://reviews.apache.org/r/37999/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
