----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107371 -----------------------------------------------------------
Patch looks great! Reviews applied: [40371] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Nov. 20, 2015, 7:45 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40371/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 7:45 a.m.) > > > Review request for mesos and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Since docker_image option could be used for mesos and docker containerizer, > introduced a new option 'containerizer' to disambiguate the two > containerizers. > > New usage: > mesos-execute --master=127.0.0.1:5050 --command="uname -a" \ > --name=test_docker --docker_image=ubuntu --containerizer=docker > > mesos-execute --master=127.0.0.1:5050 --command="uname -a" \ > --name=test_mesos --docker_image=ubuntu --containerizer=mesos > > > Diffs > ----- > > src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc > > Diff: https://reviews.apache.org/r/40371/diff/ > > > Testing > ------- > > tested the two containerizer locally with simple commands. > > > Thanks, > > Jojy Varghese > >