> On Nov. 18, 2015, 7:39 p.m., Vinod Kone wrote: > > include/mesos/uri/fetcher.hpp, line 49 > > <https://reviews.apache.org/r/40305/diff/2/?file=1127476#file1127476line49> > > > > Plugin might be confusing with Module. > > > > Not sure what's a better alternative name is, Downloader? Schema?
Schema is not good because one Plugin can handle more than one schemes. I couldn't find a better name. Since Plugin is within Fetcher namespace, and will always be used like Fetcher::Plugin. So I think it shouldn't cause confusion to Module. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40305/#review107073 ----------------------------------------------------------- On Nov. 19, 2015, 6:30 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40305/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 6:30 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-3922 > https://issues.apache.org/jira/browse/MESOS-3922 > > > Repository: mesos > > > Description > ------- > > Added URI fetcher interface. > > > Diffs > ----- > > include/mesos/uri/fetcher.hpp PRE-CREATION > src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 > src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 > src/uri/fetcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40305/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
