> On Nov. 23, 2015, 8:07 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 391 > > <https://reviews.apache.org/r/39400/diff/7/?file=1123269#file1123269line391> > > > > For this newly added member `quotaRoleSorter`, I think we also need to > > initialize it in the constructor like what we did for `roleSorter`. > > ``` > > HierarchicalAllocatorProcess( > > const std::function<Sorter*()>& _roleSorterFactory, > > const std::function<Sorter*()>& _frameworkSorterFactory) > > : ProcessBase(process::ID::generate("hierarchical-allocator")), > > initialized(false), > > metrics(*this), > > roleSorterFactory(_roleSorterFactory), > > frameworkSorterFactory(_frameworkSorterFactory), > > roleSorter(NULL) {} <--- we initialized roleSorter here. > > ```
Let's fix it in https://reviews.apache.org/r/40586/ - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review107563 ----------------------------------------------------------- On Nov. 11, 2015, 10:29 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39400/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2015, 10:29 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > cd0d3e0bd234fcf4db9af2e376ea311937204f75 > src/master/allocator/mesos/hierarchical.cpp > 14fef63714721fcda7cea3c28704766efda6d007 > > Diff: https://reviews.apache.org/r/39400/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
