----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40264/#review107632 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/clock.hpp (lines 53 - 54) <https://reviews.apache.org/r/40264/#comment166863> Let's clarify why it is ok not to execute them: that processes should have been properly finalized before the clock is finalized. 3rdparty/libprocess/src/clock.cpp (line 141) <https://reviews.apache.org/r/40264/#comment166862> Let's add a comment that `tick` must remain robust to arbitrary invocations, as per offline discussion. - Joris Van Remoortere On Nov. 20, 2015, 7:17 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40264/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 7:17 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3882 > https://issues.apache.org/jira/browse/MESOS-3882 > > > Repository: mesos > > > Description > ------- > > Timers may deference `process_manager`, either directly or via the associated > lambda, after `process_manager` has been freed in `process::finalize`. > Cleaning up the `Clock` appropriately in `process::finalize` prevents that > race. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/clock.hpp > 1107a329caf77f15901d87808eee72818601510c > 3rdparty/libprocess/src/clock.cpp 58060985bf8ab8a1bbd78b687b4c96836e13b86a > 3rdparty/libprocess/src/process.cpp > 8fa0594b671969c2713d1b361f2dbbb07d25b3a8 > > Diff: https://reviews.apache.org/r/40264/diff/ > > > Testing > ------- > > `make check` (--enable-libevent --enable-ssl) > > > Thanks, > > Joseph Wu > >
