> On Nov. 23, 2015, 2:40 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 171 > > <https://reviews.apache.org/r/40332/diff/2/?file=1135516#file1135516line171> > > > > What about rename it to recoverQuota()? > > Joris Van Remoortere wrote: > We want to have just a single recover function, just like other modules > in the master. > The fact that only quota is currently recovered in the hierarchical > allocator is a detail, not a constraint. Does this make more sense?
It's true that now we recover only quota, but I would prefer to keep `recover()` general. Other allocators (or we in the future) may use it for something different. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107539 ----------------------------------------------------------- On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40332/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 4:11 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-3981 > https://issues.apache.org/jira/browse/MESOS-3981 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > c65fe35198b846da2dc959dd467a21ff6edd30a9 > src/master/allocator/mesos/hierarchical.cpp > 2765526047767cbd19d13c11ecfa6e90c505b3a7 > > Diff: https://reviews.apache.org/r/40332/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
