----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107707 -----------------------------------------------------------
Patch looks great! Reviews applied: [40424] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Nov. 24, 2015, 2:37 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40424/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 2:37 a.m.) > > > Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu. > > > Bugs: MESOS-3791 > https://issues.apache.org/jira/browse/MESOS-3791 > > > Repository: mesos > > > Description > ------- > > In this ticket, we will enhance the existing > HTTP endpoint to query roles as outlined in > the dynamic role design Doc. > > > Diffs > ----- > > src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 > > Diff: https://reviews.apache.org/r/40424/diff/ > > > Testing > ------- > > Test results: > $ curl http://127.0.0.1:5050/roles > {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} > > $ curl http://127.0.0.1:5050/roles?roleName=aa > {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} > > > $ curl http://127.0.0.1:5050/roles?roleName=dd > The specified role [dd] does not exist! > > > Thanks, > > Yong Qiao Wang > >