> On Nov. 24, 2015, 1:52 p.m., Benjamin Bannier wrote: > > src/tests/fault_tolerance_tests.cpp, line 778 > > <https://reviews.apache.org/r/39320/diff/3/?file=1138778#file1138778line778> > > > > You should just use `master::Flags().allocation_interval` to simplify > > this.
Do you think it will be cleaner? I have following thoughts: - it extracts the default value from the `master::Flags` structs instead of being in sync with the test environment created by `CreateMasterFlags()`; - we create a complete `master::Flags` object in order to use one flag. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107780 ----------------------------------------------------------- On Nov. 24, 2015, 1:13 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39320/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 1:13 p.m.) > > > Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and > Till Toenshoff. > > > Bugs: MESOS-3732 > https://issues.apache.org/jira/browse/MESOS-3732 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > 3bbd6cbf6b101415c90991c48f00f33a5aff5590 > src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd > src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 > > Diff: https://reviews.apache.org/r/39320/diff/ > > > Testing > ------- > > make check > > The run time for the `FaultToleranceTest.FrameworkReregister` test has > reduced from more than `1s` to less than `100ms`. > Before: > ``` > [ RUN ] FaultToleranceTest.FrameworkReregister > [ OK ] FaultToleranceTest.FrameworkReregister (1018 ms) > ``` > After: > ``` > [ RUN ] FaultToleranceTest.FrameworkReregister > [ OK ] FaultToleranceTest.FrameworkReregister (49 ms) > ``` > > > Thanks, > > Alexander Rukletsov > >
