----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review108079 -----------------------------------------------------------
I'm thinking we are going to build a RoleManager as I comments in design doc; so only RoleManager will pass to allocator. Honestly, I did not want allocator to take so many responsiblity, it should focus on resource allocation. For the role management, I'd like to delegate it to RoleManager. And recently, there's a EPIC on implic role, RoleManager will also help to it. I have add a comment to its design doc to propose a role manager plugin. - Klaus Ma On Nov. 24, 2015, 10:39 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40469/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 10:39 a.m.) > > > Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu. > > > Bugs: MESOS-3956 > https://issues.apache.org/jira/browse/MESOS-3956 > > > Repository: mesos > > > Description > ------- > > Update Allocator interface to support dynamic roles > > > Diffs > ----- > > include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 > src/master/allocator/mesos/allocator.hpp > d2d32af227d66c4030becd4cd64b907a70d25f49 > src/master/allocator/mesos/hierarchical.hpp > 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 > src/master/allocator/mesos/hierarchical.cpp > f2e3b639f210eb06c70584ee7294609d9fd978ad > src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 > > Diff: https://reviews.apache.org/r/40469/diff/ > > > Testing > ------- > > Make check successfully. > > > Thanks, > > Yong Qiao Wang > >
