----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/#review108377 -----------------------------------------------------------
Ship it! Very minor things. I'll just make the changes when I commit the patch. Thanks! configure.ac (line 619) <https://reviews.apache.org/r/39634/#comment167814> End with fullstop. src/Makefile.am (line 1756) <https://reviews.apache.org/r/39634/#comment167816> Can you add a comment that FreeBSD includes the necessary functionality in libc? src/tests/attributes_tests.cpp (line 38) <https://reviews.apache.org/r/39634/#comment167813> These are unrelated to the FreeBSD support so can you split them out? Else, I'll do it when I commit this patch. - Ian Downes On Nov. 27, 2015, 8:26 p.m., David Forsythe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39634/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 8:26 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1563 > https://issues.apache.org/jira/browse/MESOS-1563 > > > Repository: mesos > > > Description > ------- > > FreeBSD: Enable mesos build and start fixing some tests > > > Diffs > ----- > > configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a > src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 > src/tests/attributes_tests.cpp d8c84d25a37f9cf1b38a97193d5b3b3001fd54ff > src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 > src/tests/values_tests.cpp fb7f982a50df8274ad29dab9e55157c39acdc104 > > Diff: https://reviews.apache.org/r/39634/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 > > > Thanks, > > David Forsythe > >
