> On Nov. 30, 2015, 10:47 a.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 393-394 > > <https://reviews.apache.org/r/40746/diff/1/?file=1147458#file1147458line393> > > > > `RemoveQuota` appears idempotent, so what is the problem with trying to > > remove a quota that is currently being removed? > > > > Is it the fact that you check this? > > ``` > > // Check that we are removing an existing quota. > > if (!master->quotas.contains(role)) { ... } > > ``` > > Alexander Rukletsov wrote: > `RemoveQuota` is idempotent, right, but > `HierarchicalAllocatorProcess::removeQuota()` is not. I think we can change > the whole function to be idempotent, but is this really necessary?
No, not really. I was just wondering what the decision behind the non-idempotency, and if it would simplify any logic by doing so :) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40746/#review108359 ----------------------------------------------------------- On Nov. 26, 2015, 4:28 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40746/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 4:28 a.m.) > > > Review request for mesos, Joris Van Remoortere and Joseph Wu. > > > Bugs: MESOS-4021 > https://issues.apache.org/jira/browse/MESOS-4021 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b > > Diff: https://reviews.apache.org/r/40746/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
