----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review108544 -----------------------------------------------------------
src/Makefile.am (line 776) <https://reviews.apache.org/r/37853/#comment167984> Please align the backslashes. We use tabs (8 spaces) in Makefiles src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (lines 59 - 68) <https://reviews.apache.org/r/37853/#comment167992> This code is copy-pasted in test as well. Can we add a utility funciton in src/linux/fs.hpp|cpp instead? ``` namespace fs { Try<bool> supported(const string& filesystem); } ``` src/tests/containerizer/provisioner_backend_tests.cpp (lines 56 - 65) <https://reviews.apache.org/r/37853/#comment167993> See my comments above. Let's add a new test filter and skip this test if overlayfs is not supported. See examples in src/tests/environment.cpp src/tests/containerizer/provisioner_backend_tests.cpp (line 109) <https://reviews.apache.org/r/37853/#comment167994> 2 lines apart. - Jie Yu On Dec. 1, 2015, 5:26 a.m., Mei Wan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37853/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 5:26 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2971 > https://issues.apache.org/jira/browse/MESOS-2971 > > > Repository: mesos > > > Description > ------- > > Implemented the overlay filesystem backend by layering the images as a > read-only filesystem. > > > Diffs > ----- > > src/CMakeLists.txt cfe9d26 > src/Makefile.am fd38cfa > src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION > src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef > > Diff: https://reviews.apache.org/r/37853/diff/ > > > Testing > ------- > > Basic test in provisioner_backend_tests.cpp. > > > Thanks, > > Mei Wan > >