> On Dec. 2, 2015, 6:32 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 248 > > <https://reviews.apache.org/r/40731/diff/2/?file=1150126#file1150126line248> > > > > More customary indentation: > > > > EXPECT_CALL(sched, resourceOffers(&driver, _)) > > .WillOnce(FutureArg<1>(&offers));
Was following this particular style guide: http://mesos.apache.org/documentation/latest/c++-style-guide/ The "Function Definition/Invocation" section wants us to follow styles 1,4, 5 and sometimes 3 and 'never' 2 hence the change? > On Dec. 2, 2015, 6:32 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 257 > > <https://reviews.apache.org/r/40731/diff/2/?file=1150126#file1150126line257> > > > > Where exactly is "over here"? Does the wait statement contain floating > > point comparisons? over here is actually the agent. Would result a crash in the agent. Will update the comment accordingly - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108696 ----------------------------------------------------------- On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40731/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 8:27 a.m.) > > > Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil > Conway. > > > Bugs: MESOS-3552 > https://issues.apache.org/jira/browse/MESOS-3552 > > > Repository: mesos > > > Description > ------- > > Adding the test framework submitted by Mandeep (@mchadha) > https://reviews.apache.org/r/39056/ > > > Diffs > ----- > > src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 > > Diff: https://reviews.apache.org/r/40731/diff/ > > > Testing > ------- > > Ran make check after adding Mandeep's test case to the GTEST framework. > > > Thanks, > > Avinash sridharan > >
