----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40985/#review109024 -----------------------------------------------------------
Ship it! src/tests/persistent_volume_tests.cpp (line 680) <https://reviews.apache.org/r/40985/#comment168435> you can kill this. - Vinod Kone On Dec. 4, 2015, 8:27 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40985/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 8:27 p.m.) > > > Review request for mesos, Michael Park and Vinod Kone. > > > Bugs: MESOS-3907 > https://issues.apache.org/jira/browse/MESOS-3907 > > > Repository: mesos > > > Description > ------- > > Fixed the flaky PersistentVolumeTest.SlaveRecovery test. > > We need to wait for the executor to re-register before advance the clock. > Otherwise, the timeout event might be handled first and result in task being > lost. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 0d162ca60f85d19421d1b4e6dbb1ceb0b31fd150 > > Diff: https://reviews.apache.org/r/40985/diff/ > > > Testing > ------- > > bin/mesos-test.sh --gtest_filter=PersistentVolumeTest.SlaveRecovery > --gtest_repeat=100 > > > Thanks, > > Jie Yu > >
