----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/#review109063 -----------------------------------------------------------
src/slave/slave.cpp (line 1503) <https://reviews.apache.org/r/39848/#comment168473> I think at this point it's worthwhile to factor out the validations in this function into slave/validation.cpp file like we have done in master/validation.cpp. The validation should likely return an object (TaskStatus?) that contains the message and REASON to be used in the status update. This would also help with unit testing the validations more easily. - Vinod Kone On Nov. 5, 2015, 7:36 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39848/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:36 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2647 > https://issues.apache.org/jira/browse/MESOS-2647 > > > Repository: mesos > > > Description > ------- > > Validates if there are enough revocable resources when launching > the task on slave. > > > Diffs > ----- > > src/slave/slave.cpp ddeece4334b13cf8b5ab7d87012bbf946640025b > > Diff: https://reviews.apache.org/r/39848/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
