----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ -----------------------------------------------------------
(Updated Dec. 8, 2015, 12:47 a.m.) Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van Remoortere. Repository: mesos Description ------- Copied missing feature updates to v1 from include/mesos/mesos.proto. This is a revised version of RR 41046 - removing the `AppcImageManifest` from V1 API again as it has been intensionally left out (as being Slave only). Diffs ----- include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068 Diff: https://reviews.apache.org/r/41060/diff/ Testing (updated) ------- For achieving this, the following was done within the tagged 0.26.0-rc3: `diff include/mesos/mesos.proto include/mesos/v1/mesos.proto` `diff include/mesos/executor.proto include/mesos/v1/executor.proto` `diff include/mesos/scheduler/scheduler.proto include/mesos/v1/scheduler/scheduler.proto` These diffs do show a couple of "slave"->"agent" renames which were ignored for this udate. The results showed that only mesos.proto was not en par with V1. We listed out all responsible review-requests; https://reviews.apache.org/r/31915 https://reviews.apache.org/r/38253 https://reviews.apache.org/r/38367 Parity on message definitions that are not purely slave related should now be achieved by this RR. We did however notice a irregularity on the non v1-proto, documented by https://issues.apache.org/jira/browse/MESOS-4091 make check (on OSX) Thanks, Till Toenshoff