----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109486 -----------------------------------------------------------
Ship it! src/tests/fetcher_tests.cpp (line 278) <https://reviews.apache.org/r/40978/#comment169061> Unneeded dead code which should be removed (otherwise should be `= default`). src/tests/fetcher_tests.cpp (line 295) <https://reviews.apache.org/r/40978/#comment169060> You could use `spawn(*process)` here to be more brief, have an additional `NULL` check, and to keep the appearance already present in `EXPECT_CALL`s here. - Benjamin Bannier On Dec. 4, 2015, 6:49 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40978/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 6:49 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Artem Harutyunyan. > > > Repository: mesos > > > Description > ------- > > This addresses the comment here: > https://reviews.apache.org/r/40501/#comment168391 > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 069c9bc6bc54d5bc1275c55e329457651d3c7b71 > > Diff: https://reviews.apache.org/r/40978/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
