----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41182/#review109671 -----------------------------------------------------------
Ship it! I shortened some of the comments, but looks great, thanks! src/tests/health_check_tests.cpp (line 278) <https://reviews.apache.org/r/41182/#comment169268> Do we need this comment given you have the ones above these blocks? - Ben Mahler On Dec. 10, 2015, 2:50 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41182/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 2:50 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4015 > https://issues.apache.org/jira/browse/MESOS-4015 > > > Repository: mesos > > > Description > ------- > > Exposed task health flag through the state endpoint on master and slave. > > > Diffs > ----- > > src/common/http.cpp 586d1c833513836ae0d4041c9f94c6332b25fdd5 > src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 > > Diff: https://reviews.apache.org/r/41182/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Artem Harutyunyan > >
